Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data.azuread_groups: support empty list for names/object_ids arguments #257

Merged
merged 2 commits into from
May 29, 2020

Conversation

manicminer
Copy link
Contributor

Support empty lists for the names and object_ids arguments, in which case no results will be returned. Aims to support the use case of the data source in a module where the input variable may be empty.

Thanks to @jpreese for the suggestion and implementation

Replaces: #231

@ghost ghost added the size/S label May 27, 2020
@manicminer manicminer requested a review from a team May 27, 2020 05:37
@manicminer manicminer changed the title data.groups: support empty list for names/object_ids arguments data.azuread_groups: support empty list for names/object_ids arguments May 27, 2020
@katbyte katbyte added this to the v0.10.0 milestone May 28, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manicminer manicminer merged commit a7c514b into master May 29, 2020
manicminer added a commit that referenced this pull request May 29, 2020
@ghost
Copy link

ghost commented Jun 5, 2020

This has been released in version 0.10.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azuread" {
    version = "~> 0.10.0"
}
# ... other configuration ...

@manicminer manicminer deleted the data/groups/support-empty-lists branch June 8, 2020 15:34
@ghost
Copy link

ghost commented Jun 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants