Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MinItems from data groups #231

Closed
wants to merge 2 commits into from

Conversation

jpreese
Copy link
Contributor

@jpreese jpreese commented Mar 19, 2020

Was trying to use the azuread_groups with the optional names parameter, but was getting an error about a value must be returned as they are both set to 1 and return an error.

Looks like a similar issue to: #227

@ghost ghost added the size/XS label Mar 19, 2020
@jpreese jpreese force-pushed the remove-groups-min branch from 20c72c5 to 6507f29 Compare March 20, 2020 00:11
@jpreese jpreese force-pushed the remove-groups-min branch from 6507f29 to b563946 Compare March 20, 2020 00:32
@ghost ghost added the documentation label Mar 20, 2020
@jpreese
Copy link
Contributor Author

jpreese commented Mar 20, 2020

For context, my use case is that a user can supply an optional value which is a list of Azure AD group names.

I take that variable, and pass it into the azuread_groups data provider, but since its optional it might be empty.

I then have another resource that does a count on the azuread_groups provider to add a resource per group that was returned. If no groups were returned, especially in the case of an empty input, don't recreate any resources.

@jpreese
Copy link
Contributor Author

jpreese commented Mar 22, 2020

As an aside, for a future PR, I think there's also value in changing the Object_IDs to be a set type. This would make it easier to use for_each and the keys should be unique.

@manicminer
Copy link
Contributor

Hi @jpreese, thanks for this change suggestion! We've discussed and believe that in this case, it's OK to support empty lists for search inputs. I've moved this to a new PR #257, preserving your contribution, as I've added a test case and clarified the new behavior in the docs.

@manicminer manicminer closed this May 27, 2020
@ghost
Copy link

ghost commented Jun 26, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants