service/eks: Implement tagging support #10307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: #10127 Updated via code changes and: ```console $ make gen ```
Reference: #10127 Output from acceptance testing: ``` --- PASS: TestAccAWSEksCluster_VpcConfig_SecurityGroupIds (1095.78s) --- PASS: TestAccAWSEksCluster_basic (1169.66s) --- PASS: TestAccAWSEksCluster_Tags (1170.71s) --- PASS: TestAccAWSEksCluster_Logging (1254.43s) --- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPublicAccess (1435.45s) --- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPrivateAccess (1625.13s) --- PASS: TestAccAWSEksCluster_Version (2354.79s) ```
Reference: #10127 Output from acceptance testing: ``` --- PASS: TestAccAWSEksClusterDataSource_basic (1278.07s) ```
bflad
added
the
enhancement
ghost
added
size/L
nywilken
approved these changes
Oct 2, 2019
There was a problem hiding this comment.
LGTM 👍 👍
--- PASS: TestAccAWSEksClusterAuthDataSource_basic (16.02s)
--- PASS: TestAccAWSEksCluster_basic (1139.62s)
--- PASS: TestAccAWSEksClusterDataSource_basic (1164.43s)
--- PASS: TestAccAWSEksCluster_VpcConfig_SecurityGroupIds (1170.70s)
--- PASS: TestAccAWSEksCluster_Logging (1234.64s)
--- PASS: TestAccAWSEksCluster_Tags (1296.68s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPublicAccess (1570.78s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPrivateAccess (1779.94s)
--- PASS: TestAccAWSEksCluster_Version (2242.80s)
bflad
added a commit
that referenced
this pull request
Oct 3, 2019
bflad
added a commit
that referenced
this pull request
Oct 3, 2019
morganchristiansson
added a commit
to morganchristiansson/terraform-aws-eks
that referenced
this pull request
Oct 3, 2019
Pending terraform-provider-aws release that includes this PR hashicorp/terraform-provider-aws#10307
4 tasks
|
This has been released in version 2.31.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
morganchristiansson
added a commit
to morganchristiansson/terraform-aws-eks
that referenced
this pull request
Oct 4, 2019
morganchristiansson
added a commit
to morganchristiansson/terraform-aws-eks
that referenced
this pull request
Oct 4, 2019
max-rocket-internet
pushed a commit
to terraform-aws-modules/terraform-aws-eks
that referenced
this pull request
Oct 4, 2019
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #10127
Release note for CHANGELOG:
Updated via code changes to
aws/internal/keyvaluetagsand:$ make genOutput from acceptance testing: