Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amazon EKS supports cluster tagging #10127

Closed
ewbankkit opened this issue Sep 17, 2019 · 4 comments · Fixed by #10307
Closed

Amazon EKS supports cluster tagging #10127

ewbankkit opened this issue Sep 17, 2019 · 4 comments · Fixed by #10307
Assignees
@bflad
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service.
Milestone
v2.31.0

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Sep 17, 2019 •
edited
Loading

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

You can now add AWS tags to your Amazon EKS clusters.

New or Affected Resource(s)

Potential Terraform Configuration

resource "aws_eks_cluster" "example" {
  tags = {
    Name = "Example cluster"
  }
}

References

Announcement.
User guide.

AWS container services roadmap issue:

Requires AWS SDK v1.23.22:

Also update:
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Sep 17, 2019
@ghost ghost added the service/eks Issues and PRs that pertain to the eks service. label Sep 17, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2019
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Sep 24, 2019
@bflad bflad self-assigned this Sep 30, 2019
@bflad bflad added this to the v2.31.0 milestone Sep 30, 2019
bflad added a commit that referenced this issue Sep 30, 2019
@bflad
internal/keyvaluetags: Support eks service
044dbd7 
Reference: #10127

Updated via code changes and:

```console
$ make gen
```
bflad added a commit that referenced this issue Sep 30, 2019
@bflad
resource/aws_eks_cluster: Add tags argument
6a19b22 
Reference: #10127

Output from acceptance testing:

```
--- PASS: TestAccAWSEksCluster_VpcConfig_SecurityGroupIds (1095.78s)
--- PASS: TestAccAWSEksCluster_basic (1169.66s)
--- PASS: TestAccAWSEksCluster_Tags (1170.71s)
--- PASS: TestAccAWSEksCluster_Logging (1254.43s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPublicAccess (1435.45s)
--- PASS: TestAccAWSEksCluster_VpcConfig_EndpointPrivateAccess (1625.13s)
--- PASS: TestAccAWSEksCluster_Version (2354.79s)
```
bflad added a commit that referenced this issue Sep 30, 2019
@bflad
data-source/aws_eks_cluster: Add tags attribute
052093c 
Reference: #10127

Output from acceptance testing:

```
--- PASS: TestAccAWSEksClusterDataSource_basic (1278.07s)
```
@bflad bflad mentioned this issue Sep 30, 2019
Merged
@bflad
Copy link
Contributor

bflad commented Sep 30, 2019

Submitted #10307 👍

@bflad
Copy link
Contributor

bflad commented Oct 3, 2019

Support for EKS tagging has been merged and will release with version 2.31.0 of the Terraform AWS Provider, tomorrow. 🚀

@ghost
Copy link

ghost commented Oct 3, 2019

This has been released in version 2.31.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bflad bflad

Labels
enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service.
Projects
None yet
Milestone
v2.31.0
Development

Successfully merging a pull request may close this issue.

service/eks: Implement tagging support hashicorp/terraform-provider-aws
2 participants
@bflad @ewbankkit