-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource/aws_emr_cluster: Add master_instance_group configuration block instance_count argument (support multiple master nodes) #9235
resource/aws_emr_cluster: Add master_instance_group configuration block instance_count argument (support multiple master nodes) #9235
Conversation
…ck instance_count argument (support multiple master nodes) Reference: #9226 Output from acceptance testing: ``` --- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceCount (1062.33s) ```
# This configuration is for illustrative purposes and highlights | ||
# only relevant configurations for working with this functionality. | ||
|
||
# Map public IP on launch must be enabled for the subnet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the docs, you can use private subnets too. From https://docs.aws.amazon.com/emr/latest/ManagementGuide/emr-plan-ha-launch.html:
You can launch an EMR cluster with multiple master nodes in both public and private VPC subnets
Same comment applies to line 347.
Is the requirement for map_public_ip_on_launch = true
a restriction of the API? Obviously, assigning a public IP on a private subnet isn't going to do anything particularly useful :)
BTW, thanks very much for such a quick turnaround on the issue I raised!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see it might only be a requirement if the cluster is in a public subnet. Do you have a working private VPC subnet multi-master setup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet; given that the restriction is only mentioned in the comments though, and not enforced in the implementation I should be able to give this a spin, time permitting, and verify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed. Your change works just fine on a private EMR cluster without the private subnets having map_public_ip_on_launch = true
in the config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, thanks, @mattburgess!
…requires public subnets to have public IP on launch Reference: #9235 (review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a suggestion on the argument documentation, but this is otherwise good to go 👍
|
Co-Authored-By: Wilken Rivera <[email protected]>
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Closes #9226
Release note for CHANGELOG:
Output from acceptance testing: