Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EMR: Support multiple master nodes #9226

Closed
mattburgess opened this issue Jul 3, 2019 · 3 comments · Fixed by #9235
Closed

EMR: Support multiple master nodes #9226

mattburgess opened this issue Jul 3, 2019 · 3 comments · Fixed by #9235
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/emr Issues and PRs that pertain to the emr service.
Milestone
v2.20.0

Comments

@mattburgess
Copy link
Collaborator

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Since EMR-5.23.0 it's possible to specify that you want multiple master nodes in an EMR cluster for HA.

I couldn't immediately see a way of requesting that via Terraform.

New or Affected Resource(s)

  • aws_emr_cluster
    • master_instance_group

Potential Terraform Configuration

resource "aws_emr_cluster" "example" {
    master_instance_group {
        instance_type = "m4.large"
        instance_count = "3"
    }
}

References
@mattburgess mattburgess added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 3, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 3, 2019
@bflad bflad added service/emr Issues and PRs that pertain to the emr service. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 3, 2019
bflad added a commit that referenced this issue Jul 4, 2019
@bflad
resource/aws_emr_cluster: Add master_instance_group configuration blo…
5b1e6cc 
…ck instance_count argument (support multiple master nodes)

Reference: #9226

Output from acceptance testing:

```
--- PASS: TestAccAWSEMRCluster_MasterInstanceGroup_InstanceCount (1062.33s)
```
@bflad bflad mentioned this issue Jul 4, 2019
Merged
@bflad
Copy link
Contributor

bflad commented Jul 4, 2019

Indeed! I have submitted an update to the aws_emr_cluster resource here to support the new instance_count argument for the master_instance_group configuration block: #9235

@bflad bflad added this to the v2.20.0 milestone Jul 16, 2019
@bflad
Copy link
Contributor

bflad commented Jul 16, 2019

Support for this has been merged and will release with version 2.20.0 of the Terraform AWS Provider, later this week. 👍

@ghost
Copy link

ghost commented Nov 2, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/emr Issues and PRs that pertain to the emr service.
Projects
None yet
Milestone
v2.20.0
2 participants
@bflad @mattburgess