Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_route53_health_check: Various small improvements #6460

Merged
merged 3 commits into from
Nov 14, 2018
Merged

resource/aws_route53_health_check: Various small improvements #6460

merged 3 commits into from
Nov 14, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Nov 14, 2018

Closes #6346
Closes #6393

Changes proposed in this pull request:

  • docs/resource/aws_route53_health_check: Improve examples and note valid search_string usage
  • resource/aws_route53_health_check: Provide plan-time validation for type
  • resource/aws_route53_health_check: Properly read child_healthchecks into Terraform state
  • tests/resource/aws_route53_health_check: Verify resource import in all acceptance tests

Output from acceptance testing:

--- PASS: TestAccAWSRoute53HealthCheck_IpConfig (11.58s)
--- PASS: TestAccAWSRoute53HealthCheck_withChildHealthChecks (13.70s)
--- PASS: TestAccAWSRoute53HealthCheck_withHealthCheckRegions (15.13s)
--- PASS: TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck (17.18s)
--- PASS: TestAccAWSRoute53HealthCheck_basic (17.91s)
--- PASS: TestAccAWSRoute53HealthCheck_withSearchString (18.99s)
--- PASS: TestAccAWSRoute53HealthCheck_withSNI (32.58s)

@bflad
docs/resource/aws_route53_health_check: Improve examples and note val…
66649c6 
…id search_string usage
@bflad
resource/aws_route53_health_check: Provide plan-time validation for t…
70c68ff 
…ype and properly read child_healthchecks into Terraform state
@bflad
tests/resource/aws_route53_health_check: Verify resource import in al…
19fe71e 
…l acceptance tests

```
--- PASS: TestAccAWSRoute53HealthCheck_IpConfig (11.58s)
--- PASS: TestAccAWSRoute53HealthCheck_withChildHealthChecks (13.70s)
--- PASS: TestAccAWSRoute53HealthCheck_withHealthCheckRegions (15.13s)
--- PASS: TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck (17.18s)
--- PASS: TestAccAWSRoute53HealthCheck_basic (17.91s)
--- PASS: TestAccAWSRoute53HealthCheck_withSearchString (18.99s)
--- PASS: TestAccAWSRoute53HealthCheck_withSNI (32.58s)
```
@bflad bflad added bug Addresses a defect in current functionality. enhancement Requests to existing resources that expand the functionality or scope. documentation Introduces or discusses updates to documentation. service/route53 Issues and PRs that pertain to the route53 service. labels Nov 14, 2018
@bflad bflad requested a review from a team November 14, 2018 15:06
@ghost ghost added size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Nov 14, 2018
@bflad bflad mentioned this pull request Nov 14, 2018
Closed
tombuildsstuff
tombuildsstuff approved these changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor 🤔 but this otherwise LGTM 👍

aws/resource_aws_route53_health_check.go
route53.HealthCheckTypeHttps,
route53.HealthCheckTypeHttpsStrMatch,
route53.HealthCheckTypeTcp,
}, true),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason this is case-insensitive?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry because the StateFunc right above is explicitly converting things to uppercase. My guess is that the API accepts both casings, so to keep that support for existing configurations, turned off case sensitivity here for validation.

@bflad bflad added this to the v1.44.0 milestone Nov 14, 2018
@bflad bflad merged commit 46763ff into master Nov 14, 2018
@bflad bflad deleted the f-aws_route53_health_check-type-validation branch November 14, 2018 17:38
bflad added a commit that referenced this pull request Nov 14, 2018
@bflad
Update CHANGELOG for #6460
7fb25e6
@bflad
Copy link
Contributor Author

bflad commented Nov 15, 2018

This has been released in version 1.44.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@mdlavin mdlavin mentioned this pull request Nov 21, 2018
Closed
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/route53 Issues and PRs that pertain to the route53 service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.44.0
Development

Successfully merging this pull request may close these issues.

AWS Route 53 health check search string error Route53 Health check error
2 participants
@bflad @tombuildsstuff