Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_route53_health_check: Various small improvements #6460

Merged
merged 3 commits into from
Nov 14, 2018
Merged

resource/aws_route53_health_check: Various small improvements #6460

merged 3 commits into from
Nov 14, 2018

Commits on Nov 14, 2018

  1. docs/resource/aws_route53_health_check: Improve examples and note val… 

    …id search_string usage
    @bflad
    bflad committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    66649c6 View commit details
    Browse the repository at this point in the history

  2. resource/aws_route53_health_check: Provide plan-time validation for t… 

    …ype and properly read child_healthchecks into Terraform state
    @bflad
    bflad committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    70c68ff View commit details
    Browse the repository at this point in the history

  3. tests/resource/aws_route53_health_check: Verify resource import in al… 

    …l acceptance tests

```
--- PASS: TestAccAWSRoute53HealthCheck_IpConfig (11.58s)
--- PASS: TestAccAWSRoute53HealthCheck_withChildHealthChecks (13.70s)
--- PASS: TestAccAWSRoute53HealthCheck_withHealthCheckRegions (15.13s)
--- PASS: TestAccAWSRoute53HealthCheck_CloudWatchAlarmCheck (17.18s)
--- PASS: TestAccAWSRoute53HealthCheck_basic (17.91s)
--- PASS: TestAccAWSRoute53HealthCheck_withSearchString (18.99s)
--- PASS: TestAccAWSRoute53HealthCheck_withSNI (32.58s)
```
    @bflad
    bflad committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    19fe71e View commit details
    Browse the repository at this point in the history