Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix force new behavior for aws_batch_job_definition timeout #4697

Merged

Conversation

hectcastro
Copy link
Contributor

Fixes #4696

Changes proposed in this pull request:

When the timeout.attempt_duration_seconds attribute of the aws_batch_job_definition is modified, ensure that a new resource is created vs. update-in-place (update-in-place is not support for this resource).

  • Add ForceNew to aws_batch_job_definition.timeout.attempt_duration_seconds

When the `timeout.attempt_duration_seconds` attribute of the
`aws_batch_job_definition` is modified, ensure that a new resource is
created vs. update-in-place (update-in-place is not support for this
resource).
@ghost ghost added the size/XS Managed by automation to categorize the size of a PR. label May 30, 2018
@bflad bflad added bug Addresses a defect in current functionality. service/batch Issues and PRs that pertain to the batch service. labels May 30, 2018
@bflad bflad added this to the v1.21.0 milestone May 30, 2018
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! We should probably also fix the retry_strategy attempts attribute as well at some point. 🚀

@bflad bflad merged commit 7954541 into hashicorp:master May 30, 2018
bflad added a commit that referenced this pull request May 30, 2018
@bflad
Copy link
Contributor

bflad commented May 31, 2018

This has been released in version 1.21.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@hectcastro hectcastro deleted the hmc/fix-batch-job-definition-timeout branch June 16, 2018 03:04
@hectcastro hectcastro restored the hmc/fix-batch-job-definition-timeout branch June 16, 2018 03:04
@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/batch Issues and PRs that pertain to the batch service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_batch_job_definition timeout parameter needs to trigger resource recreation
2 participants