Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_batch_job_definition timeout parameter needs to trigger resource recreation #4696

Closed
hectcastro opened this issue May 30, 2018 · 4 comments · Fixed by #4697
Closed

aws_batch_job_definition timeout parameter needs to trigger resource recreation #4696

hectcastro opened this issue May 30, 2018 · 4 comments · Fixed by #4697
Labels
bug Addresses a defect in current functionality. service/batch Issues and PRs that pertain to the batch service.
Milestone

Comments

@hectcastro
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Terraform Version

Terraform v0.11.7

Affected Resource(s)

  • aws_batch_job_definition

Terraform Configuration Files

resource "aws_batch_job_definition" "ingest_scene" {
  name = "jobIngestScene"
  type = "container"

  container_properties = "${data.template_file.ingest_scene_job_definition.rendered}"

  parameters {
    sceneId = " "
  }

  retry_strategy {
    attempts = 3
  }

  timeout {
    attempt_duration_seconds = 7200
  }
}

Expected Behavior

When timeout.attempt_duration_seconds is updated, the corresponding task definition should reflect the change.

Actual Behavior

When timeout.attempt_duration_seconds is updated, Terraform attempts to update the attribute, but the resource does not support updates.

* aws_batch_job_definition.ingest_scene: 1 error(s) occurred:

* aws_batch_job_definition.ingest_scene: doesn't support update

Steps to Reproduce

  1. Modify the existing timeout parameter of a aws_batch_job_definition
  2. terraform apply
  3. See the error message above
@bflad bflad added bug Addresses a defect in current functionality. service/batch Issues and PRs that pertain to the batch service. labels May 30, 2018
@bflad bflad added this to the v1.21.0 milestone May 30, 2018
@bflad
Copy link
Contributor

bflad commented May 30, 2018

Thanks for reporting this! Looks like the top level timeout attribute was marked ForceNew: true but not the underlying attempt_duration_seconds attribute:

https://github.com/terraform-providers/terraform-provider-aws/blob/333abdf5cc9956f777ffd08e904fff86d9690e38/aws/resource_aws_batch_job_definition.go#L60-L74

If you would like to submit the one-line fix, I'll gladly turbo-merge it and we can get it released. 👍

@hectcastro
Copy link
Contributor Author

Thank you, sir. 💨🐰

@bflad
Copy link
Contributor

bflad commented May 31, 2018

This has been released in version 1.21.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/batch Issues and PRs that pertain to the batch service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants