service/neptune: enable CloudwatchLogsExports of type audit

[ericksoen]

Overview

Add a new schema property to allow users to ship audit logs for their Neptune cluster to Cloudwatch.

Notes

The glob pattern (e.g., TestAccAWSNeptuneCluster ) to run all the acceptance tests for this resource causes failures since each of the test cases use acctest.RandInt() in the resource name, causing non-unique resource names and resource contention.

If appropriate, I can amend the PR to generate unique resource names via acctest.RandString() to allow all the acceptance tests to run in parallel successfully. (I haven't made enough contributions to this repo yet to familiarize myself with the conventions regarding best practices for resource naming in test cases or "appropriately sized PRs").

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #9094

Release note for CHANGELOG:

resource/aws_neptune_cloudwatch_cluster: enable audit type CloudwatchLogsExports

Output from acceptance testing:

make testacc TEST=./aws TESTARGS='-run=TestAccAWSNeptuneCluster_updateCloudwatchLogsExports'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSNeptuneCluster_updateCloudwatchLogsExports -timeout 120m
=== RUN   TestAccAWSNeptuneCluster_updateCloudwatchLogsExports
=== PAUSE TestAccAWSNeptuneCluster_updateCloudwatchLogsExports
=== CONT  TestAccAWSNeptuneCluster_updateCloudwatchLogsExports
--- PASS: TestAccAWSNeptuneCluster_updateCloudwatchLogsExports (215.32s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       215.530s...

[bflad]

Looks good, thanks @ericksoen 🚀 As for the other testing issues, they will likely be resolved via #11731 (although yes, we generally prefer changes be separated for easier review).

Output from acceptance testing:

--- PASS: TestAccAWSNeptuneCluster_namePrefix (105.49s)
--- PASS: TestAccAWSNeptuneCluster_basic (124.42s)
--- PASS: TestAccAWSNeptuneCluster_encrypted (146.13s)
--- PASS: TestAccAWSNeptuneCluster_updateTags (151.23s)
--- PASS: TestAccAWSNeptuneCluster_takeFinalSnapshot (165.88s)
--- PASS: TestAccAWSNeptuneCluster_iamAuth (152.33s)
--- PASS: TestAccAWSNeptuneCluster_updateIamRoles (171.70s)
--- PASS: TestAccAWSNeptuneCluster_backupsUpdate (177.56s)
--- PASS: TestAccAWSNeptuneCluster_kmsKey (194.86s)
--- PASS: TestAccAWSNeptuneCluster_updateCloudwatchLogsExports (192.68s)

[ghost]

This has been released in version 2.49.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!