r/neptune_cluster - support delete protection

[DrFaust92]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource_aws_neptune_cluster: add `deletion_protection` argument.
resource_aws_neptune_cluster: add plan time validation for `iam_roles`.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSNeptuneCluster_'
--- PASS: TestAccAWSNeptuneCluster_basic (164.67s)
--- PASS: TestAccAWSNeptuneCluster_tags (227.02s)
--- PASS: TestAccAWSNeptuneCluster_kmsKey (197.13s)
--- PASS: TestAccAWSNeptuneCluster_encrypted (183.68s)
--- PASS: TestAccAWSNeptuneCluster_backupsUpdate (180.87s)
--- PASS: TestAccAWSNeptuneCluster_iamAuth (129.55s)
--- PASS: TestAccAWSNeptuneCluster_takeFinalSnapshot (230.35s)
--- PASS: TestAccAWSNeptuneCluster_namePrefix (156.87s)
--- PASS: TestAccAWSNeptuneCluster_updateIamRoles (236.64s)
--- PASS: TestAccAWSNeptuneCluster_basic (173.67s)
--- PASS: TestAccAWSNeptuneCluster_deleteProtection (272.79s)
--- PASS: TestAccAWSNeptuneCluster_updateCloudwatchLogsExports (253.75s)

[slapula]

LGTM

[bflad]

Hi @DrFaust92 👋 Looking good, just please see the below initial feedback and let us know if you have questions or do not have time to implement.

[DrFaust92]

@bflad, Thanks for the comments! rebased and updated accordingly. tests are passing

[bflad]

Looks good, thanks so much, @DrFaust92 🚀

Output from acceptance testing:

--- PASS: TestAccAWSNeptuneCluster_tags (126.60s)
--- PASS: TestAccAWSNeptuneCluster_namePrefix (145.71s)
--- PASS: TestAccAWSNeptuneCluster_encrypted (146.50s)
--- PASS: TestAccAWSNeptuneCluster_basic (148.04s)
--- PASS: TestAccAWSNeptuneCluster_iamAuth (133.02s)
--- PASS: TestAccAWSNeptuneCluster_kmsKey (165.98s)
--- PASS: TestAccAWSNeptuneCluster_backupsUpdate (157.23s)
--- PASS: TestAccAWSNeptuneCluster_updateIamRoles (173.01s)
--- PASS: TestAccAWSNeptuneCluster_updateCloudwatchLogsExports (162.96s)
--- PASS: TestAccAWSNeptuneCluster_takeFinalSnapshot (215.86s)
--- PASS: TestAccAWSNeptuneCluster_deleteProtection (252.43s)

[ghost]

This has been released in version 2.49.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!