Fix file arguments handling when using --chdir #1636
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filtering issues by file arguments did not work properly with
--chdir
:This PR fixes this issue by parsing the arguments after the directory change. So
tflint --chdir=subdir main.tf
works.This may seem counterintuitive at first glance, but in the current model where
--chdir
is applied first, it makes sense that the path is relative to the changed working directory.To further prevent misunderstandings, file arguments will also be deprecated in the future. Instead, it provides an option like
--filter
, implying that the behavior is to filter issues after inspection of a directory, rather than inspecting only specific files.