Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose cbr variable #349

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

feat: expose cbr variable #349

wants to merge 14 commits into from

Conversation

Khuzaima05
Copy link
Member

Description

expose cbr variable

issue: https://github.ibm.com/orgs/GoldenEye/projects/3/views/1?filterQuery=assignee%3A%40me&pane=issue&itemId=430995

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05 Khuzaima05 self-assigned this Nov 4, 2024
Copy link
Member

@Ak-sky Ak-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left few comments.

variables.tf Show resolved Hide resolved
examples/end-to-end-example/main.tf Outdated Show resolved Hide resolved
@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@ocofaigh
Copy link
Member

I see the test is failing with below error. @Khuzaima05 Perhaps you need to set use_private_endpoint to true, however it seems that variable does not exist in this module, but it does exist in base OCP. cc @Aashiq-J

 2024/11/19 08:32:19 Terraform apply | Error: local-exec provisioner error
 2024/11/19 08:32:19 Terraform apply | 
 2024/11/19 08:32:19 Terraform apply |   with module.ocp_all_inclusive.module.ocp_base.null_resource.reset_api_key,
 2024/11/19 08:32:19 Terraform apply |   on .terraform/modules/ocp_all_inclusive.ocp_base/main.tf line 286, in resource "null_resource" "reset_api_key":
 2024/11/19 08:32:19 Terraform apply |  286:   provisioner "local-exec" {
 2024/11/19 08:32:19 Terraform apply | 
 2024/11/19 08:32:19 Terraform apply | Error running command
 2024/11/19 08:32:19 Terraform apply | '.terraform/modules/ocp_all_inclusive.ocp_base/scripts/reset_iks_api_key.sh
 2024/11/19 08:32:19 Terraform apply | au-syd 92a58d9310e540f69e15553be47c7180 false default': exit status 1.
 2024/11/19 08:32:19 Terraform apply | Output: ERROR:: FAILED TO RESET THE IAM API KEY
 2024/11/19 08:32:19 Terraform apply | HTTP/2 500 
 2024/11/19 08:32:19 Terraform apply | content-type: application/json; charset=utf-8
 2024/11/19 08:32:19 Terraform apply | x-carrier: prod-syd01-carrier102
 2024/11/19 08:32:19 Terraform apply | x-correlation-id: 8c0290fd-71b7-4f5a-8c8d-19f088b18f63
 2024/11/19 08:32:19 Terraform apply | x-hostname: armada-global-api-7f4d6ddc8d-blt5m
 2024/11/19 08:32:19 Terraform apply | x-region: au-syd
 2024/11/19 08:32:19 Terraform apply | x-request-id: c40bc120-b278-497a-8e19-c67d11c55e2f
 2024/11/19 08:32:19 Terraform apply | content-length: 197
 2024/11/19 08:32:19 Terraform apply | content-security-policy: default-src 'none'; script-src 'self'
 2024/11/19 08:32:19 Terraform apply | 'unsafe-inline' 'unsafe-eval'; connect-src 'self'; img-src 'self' data:;
 2024/11/19 08:32:19 Terraform apply | style-src 'self' 'unsafe-inline'; font-src 'self'
 2024/11/19 08:32:19 Terraform apply | strict-transport-security: max-age=31536000; includeSubDomains
 2024/11/19 08:32:19 Terraform apply | x-content-type-options: nosniff
 2024/11/19 08:32:19 Terraform apply | x-frame-options: DENY
 2024/11/19 08:32:19 Terraform apply | x-permitted-cross-domain-policies: master-only
 2024/11/19 08:32:19 Terraform apply | x-xss-protection: 1; mode=block
 2024/11/19 08:32:19 Terraform apply | expires: Tue, 19 Nov 2024 08:30:05 GMT
 2024/11/19 08:32:19 Terraform apply | cache-control: max-age=0, no-cache, no-store
 2024/11/19 08:32:19 Terraform apply | pragma: no-cache
 2024/11/19 08:32:19 Terraform apply | date: Tue, 19 Nov 2024 08:30:05 GMT
 2024/11/19 08:32:19 Terraform apply | server-timing: cdn-cache; desc=MISS
 2024/11/19 08:32:19 Terraform apply | server-timing: edge; dur=287
 2024/11/19 08:32:19 Terraform apply | server-timing: origin; dur=6012
 2024/11/19 08:32:19 Terraform apply | server-timing: ak_p;
 2024/11/19 08:32:19 Terraform apply | desc="1732004998727_389073029_2743039028_628690_2761_1_3_15";dur=1
 2024/11/19 08:32:19 Terraform apply | 
 2024/11/19 08:32:19 Terraform apply | {"incidentID":"c40bc120-b278-497a-8e19-c67d11c55e2f,c40bc120-b278-497a-8e19-c67d11c55e2f","code":"A0862a","description":"Could
 2024/11/19 08:32:19 Terraform apply | not connect to IAM service. Try again later.","type":"Authentication"}

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

Pipeline is failing with known issue: https://github.ibm.com/GoldenEye/issues/issues/10743

Screenshot 2024-11-20 at 11 39 16 PM

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

@Khuzaima05
Copy link
Member Author

/run pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants