Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose enable_hub variable #661

Merged
merged 1 commit into from
Nov 7, 2023
Merged

feat: expose enable_hub variable #661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .secrets.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"files": "go.sum|^.secrets.baseline$",
"lines": null
},
"generated_at": "2023-06-03T04:36:46Z",
"generated_at": "2023-11-07T13:53:51Z",
"plugins_used": [
{
"name": "AWSKeyDetector"
Expand Down
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ To attach access management tags to resources in this module, you need the follo
| Name | Version |
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.3.0, <1.6.0 |
| <a name="requirement_ibm"></a> [ibm](#requirement\_ibm) | >= 1.56.0 |
| <a name="requirement_ibm"></a> [ibm](#requirement\_ibm) | >= 1.58.0 |
| <a name="requirement_time"></a> [time](#requirement\_time) | >= 0.9.1 |

### Modules
Expand Down Expand Up @@ -133,6 +133,7 @@ To attach access management tags to resources in this module, you need the follo
| <a name="input_default_network_acl_name"></a> [default\_network\_acl\_name](#input\_default\_network\_acl\_name) | OPTIONAL - Name of the Default ACL. If null, a name will be automatically generated | `string` | `null` | no |
| <a name="input_default_routing_table_name"></a> [default\_routing\_table\_name](#input\_default\_routing\_table\_name) | OPTIONAL - Name of the Default Routing Table. If null, a name will be automatically generated | `string` | `null` | no |
| <a name="input_default_security_group_name"></a> [default\_security\_group\_name](#input\_default\_security\_group\_name) | OPTIONAL - Name of the Default Security Group. If null, a name will be automatically generated | `string` | `null` | no |
| <a name="input_enable_hub"></a> [enable\_hub](#input\_enable\_hub) | Indicates whether this VPC is enabled as a DNS name resolution hub. | `bool` | `false` | no |
| <a name="input_enable_vpc_flow_logs"></a> [enable\_vpc\_flow\_logs](#input\_enable\_vpc\_flow\_logs) | Flag to enable vpc flow logs. If true, flow log collector will be created | `bool` | `false` | no |
| <a name="input_existing_cos_instance_guid"></a> [existing\_cos\_instance\_guid](#input\_existing\_cos\_instance\_guid) | GUID of the COS instance to create Flow log collector | `string` | `null` | no |
| <a name="input_existing_storage_bucket_name"></a> [existing\_storage\_bucket\_name](#input\_existing\_storage\_bucket\_name) | Name of the COS bucket to collect VPC flow logs | `string` | `null` | no |
Expand Down
2 changes: 1 addition & 1 deletion common-dev-assets
Open in desktop
Submodule common-dev-assets updated 4 files
+8 −18 common-go-assets/cloudinfo-region-power-prefs.yaml
+1 −1 module-assets/ci/install-deps.sh
+2 −1 module-assets/ci/run-tests.sh
+1 −1 module-assets/ci/trigger-catalog-onboarding-pipeline.sh
2 changes: 1 addition & 1 deletion examples/basic/version.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
# Pin to the lowest provider version of the range defined in the main module's version.tf to ensure lowest version still works
ibm = {
source = "IBM-Cloud/ibm"
version = "1.56.0"
version = "1.58.0"
}
}
}
2 changes: 1 addition & 1 deletion examples/default/version.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
# Pin to the lowest provider version of the range defined in the main module's version.tf to ensure lowest version still works
ibm = {
source = "IBM-Cloud/ibm"
version = "1.56.0"
version = "1.58.0"
}
}
}
2 changes: 1 addition & 1 deletion examples/landing_zone/version.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ terraform {
required_providers {
ibm = {
source = "IBM-Cloud/ibm"
version = ">= 1.56.0"
version = ">= 1.58.0"
}
}
}
2 changes: 1 addition & 1 deletion examples/no-prefix/version.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
# Pin to the lowest provider version of the range defined in the main module's version.tf to ensure lowest version still works
ibm = {
source = "IBM-Cloud/ibm"
version = "1.56.0"
version = "1.58.0"
}
}
}
4 changes: 4 additions & 0 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@ resource "ibm_is_vpc" "vpc" {
tags = var.tags
access_tags = var.access_tags
no_sg_acl_rules = var.clean_default_sg_acl

dns {
enable_hub = var.enable_hub
}
}

##############################################################################
Expand Down
28 changes: 19 additions & 9 deletions module-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,16 @@
"matches": "^([a-z]|[a-z][-a-z0-9]*[a-z0-9])$",
"computed": true
},
"enable_hub": {
"name": "enable_hub",
"type": "bool",
"description": "Indicates whether this VPC is enabled as a DNS name resolution hub.",
"default": false,
"pos": {
"filename": "variables.tf",
"line": 463
}
},
"enable_vpc_flow_logs": {
"name": "enable_vpc_flow_logs",
"type": "bool",
Expand Down Expand Up @@ -518,7 +528,7 @@
"ibm": {
"source": "IBM-Cloud/ibm",
"version_constraints": [
"\u003e= 1.56.0"
"\u003e= 1.58.0"
]
},
"time": {
Expand All @@ -542,7 +552,7 @@
},
"pos": {
"filename": "main.tf",
"line": 124
"line": 128
}
},
"ibm_is_flow_log.flow_logs": {
Expand All @@ -563,7 +573,7 @@
},
"pos": {
"filename": "main.tf",
"line": 135
"line": 139
}
},
"ibm_is_network_acl.network_acl": {
Expand Down Expand Up @@ -598,7 +608,7 @@
},
"pos": {
"filename": "main.tf",
"line": 102
"line": 106
}
},
"ibm_is_security_group_rule.default_vpc_rule": {
Expand Down Expand Up @@ -663,7 +673,7 @@
},
"pos": {
"filename": "main.tf",
"line": 42
"line": 46
}
},
"ibm_is_vpc_address_prefix.subnet_prefix": {
Expand All @@ -690,7 +700,7 @@
},
"pos": {
"filename": "main.tf",
"line": 67
"line": 71
}
},
"ibm_is_vpc_routing_table_route.routing_table_routes": {
Expand All @@ -705,7 +715,7 @@
},
"pos": {
"filename": "main.tf",
"line": 76
"line": 80
}
},
"time_sleep.wait_for_authorization_policy": {
Expand All @@ -717,7 +727,7 @@
},
"pos": {
"filename": "main.tf",
"line": 57
"line": 61
}
}
},
Expand All @@ -731,7 +741,7 @@
},
"pos": {
"filename": "main.tf",
"line": 50
"line": 54
}
}
},
Expand Down
10 changes: 10 additions & 0 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,3 +455,13 @@ variable "is_flow_log_collector_active" {
}

##############################################################################

##############################################################################
# VPC Hub-Spoke support
##############################################################################

variable "enable_hub" {
description = "Indicates whether this VPC is enabled as a DNS name resolution hub."
type = bool
default = false
}
2 changes: 1 addition & 1 deletion version.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ terraform {
# Use "greater than or equal to" range in modules
ibm = {
source = "IBM-Cloud/ibm"
version = ">= 1.56.0"
version = ">= 1.58.0"
}
time = {
source = "hashicorp/time"
Expand Down