Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add workaround #191

Merged
merged 2 commits into from
Aug 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ You need the following permissions to run this module.
|------|---------|
| <a name="requirement_terraform"></a> [terraform](#requirement\_terraform) | >= 1.3.0 |
| <a name="requirement_ibm"></a> [ibm](#requirement\_ibm) | >= 1.54.0, < 2.0.0 |
| <a name="requirement_time"></a> [time](#requirement\_time) | >= 0.9.1 |

## Modules

Expand All @@ -66,6 +67,7 @@ You need the following permissions to run this module.
| [ibm_database.redis_database](https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/database) | resource |
| [ibm_iam_authorization_policy.kms_policy](https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/iam_authorization_policy) | resource |
| [ibm_resource_key.service_credentials](https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/resource_key) | resource |
| [time_sleep.wait_for_authorization_policy](https://registry.terraform.io/providers/hashicorp/time/latest/docs/resources/sleep) | resource |
| [ibm_database_connection.database_connection](https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/data-sources/database_connection) | data source |

## Inputs
Expand Down
7 changes: 7 additions & 0 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,13 @@ resource "ibm_iam_authorization_policy" "kms_policy" {
roles = ["Reader"]
}

# workaround for https://github.com/IBM-Cloud/terraform-provider-ibm/issues/4478
resource "time_sleep" "wait_for_authorization_policy" {
depends_on = [ibm_iam_authorization_policy.kms_policy]

create_duration = "30s"
}

resource "ibm_database" "redis_database" {
depends_on = [ibm_iam_authorization_policy.kms_policy]
name = var.instance_name
Expand Down
26 changes: 22 additions & 4 deletions module-metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,12 @@
"version_constraints": [
"\u003e= 1.54.0, \u003c 2.0.0"
]
},
"time": {
"source": "hashicorp/time",
"version_constraints": [
"\u003e= 0.9.1"
]
}
},
"managed_resources": {
Expand All @@ -403,7 +409,7 @@
},
"pos": {
"filename": "main.tf",
"line": 42
"line": 49
}
},
"ibm_iam_authorization_policy.kms_policy": {
Expand Down Expand Up @@ -435,7 +441,19 @@
},
"pos": {
"filename": "main.tf",
"line": 178
"line": 185
}
},
"time_sleep.wait_for_authorization_policy": {
"mode": "managed",
"type": "time_sleep",
"name": "wait_for_authorization_policy",
"provider": {
"name": "time"
},
"pos": {
"filename": "main.tf",
"line": 43
}
}
},
Expand All @@ -455,7 +473,7 @@
},
"pos": {
"filename": "main.tf",
"line": 206
"line": 213
}
}
},
Expand Down Expand Up @@ -534,7 +552,7 @@
},
"pos": {
"filename": "main.tf",
"line": 138
"line": 145
}
}
}
Expand Down
4 changes: 4 additions & 0 deletions version.tf
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,9 @@ terraform {
# Use "greater than or equal to" range in modules
version = ">= 1.54.0, < 2.0.0"
}
time = {
source = "hashicorp/time"
version = ">= 0.9.1"
}
}
}