Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add warning message if go mod pre-commit hook fails #764

Merged
merged 5 commits into from
Sep 29, 2023
Merged

Conversation

akocbek
Copy link
Contributor

@akocbek akocbek commented Sep 27, 2023

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

  • When merging, use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
  • Merge by using "Squash and merge".

replace_module = True
break
if replace_module:
lines[index] = expected_line + "\n"
with open(path, "w") as writer:
writer.writelines(lines)
print(
"warning: If repository name has changed, then update 'remote.origin.url' locally by running 'git remote set-url origin new_repo_url'."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or re-clone the repo using the new repo name

@ocofaigh ocofaigh merged commit f8b19a2 into main Sep 29, 2023
@ocofaigh ocofaigh deleted the mod_fix branch September 29, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants