Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fix to golangci linter hook #1081

Merged
merged 1 commit into from
Dec 17, 2024
Merged

add fix to golangci linter hook #1081

merged 1 commit into from
Dec 17, 2024

Conversation

ocofaigh
Copy link
Member

@ocofaigh ocofaigh commented Dec 17, 2024

Description

pre-commit are failing when they run inside the renovate docker image:

[INFO] Installing environment for local.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
An unexpected error has occurred: FileNotFoundError: [Errno 2] No such file or directory: '/tmp/containerbase/cache/.cache/pre-commit/repo608oo3ko/golangenv-system/.install_state_v1staging'
Check the log at /tmp/containerbase/cache/.cache/pre-commit/pre-commit.log

Looks like same issue was reported in pre-commit/pre-commit#3219 and the suggested fix was to change to use system. I tested locally and in the image and it seems to work.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh ocofaigh merged commit b78d710 into main Dec 17, 2024
1 check passed
@ocofaigh ocofaigh deleted the ocofaigh-patch-1 branch December 17, 2024 19:52
@ocofaigh ocofaigh mentioned this pull request Dec 17, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants