Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lint ibm_catalog.json #1059

Merged
merged 4 commits into from
Nov 11, 2024
Merged

feat: lint ibm_catalog.json #1059

merged 4 commits into from
Nov 11, 2024

Conversation

kierramarie
Copy link
Contributor

Description

Added hook to pre-commit yaml to lint the ibm-catalog.json according to its schema.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@kierramarie kierramarie requested a review from ocofaigh as a code owner October 31, 2024 15:19
@kierramarie
Copy link
Contributor Author

@ocofaigh ocofaigh merged commit 68d44fc into main Nov 11, 2024
1 check passed
@ocofaigh ocofaigh deleted the ks-ibm-catalog-lint branch November 11, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants