Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Terraform 0.12 #52 #53

Merged
merged 5 commits into from
Sep 25, 2019
Merged

Add support for Terraform 0.12 #52 #53

merged 5 commits into from
Sep 25, 2019

Conversation

ingwarr
Copy link
Contributor

@ingwarr ingwarr commented Aug 5, 2019

Fixes #52

@ingwarr ingwarr mentioned this pull request Aug 5, 2019
Closed
kopachevsky
kopachevsky reviewed Aug 5, 2019
View reviewed changes
Makefile Outdated Show resolved Hide resolved
kopachevsky
kopachevsky suggested changes Aug 5, 2019
View reviewed changes
README.md Outdated Show resolved Hide resolved
examples/mysql-and-postgres/main.tf Show resolved Hide resolved
examples/mysql-and-postgres/main.tf Show resolved Hide resolved
examples/mysql-and-postgres/outputs.tf Outdated Show resolved Hide resolved
test/fixtures/mysql-ha/main.tf Show resolved Hide resolved
test/fixtures/mysql-simple/outputs.tf Outdated Show resolved Hide resolved
test/fixtures/postgresql-ha/main.tf Show resolved Hide resolved
test/make.sh Outdated Show resolved Hide resolved
test/make.sh Show resolved Hide resolved
test/make.sh Show resolved Hide resolved
@ingwarr ingwarr force-pushed the master branch 3 times, most recently from 53d8228 to 74db222 Compare August 5, 2019 18:04
@ingwarr
Copy link
Contributor Author

ingwarr commented Aug 5, 2019

All tests passed, for safer-mysql-simple-local and private-service-access-local kitchen converge should be run 2 times because of bug, maybe we need to refactor modules/private_service_access
image
image
image
image
image
image
image
image
image

nick4fake
nick4fake previously requested changes Aug 7, 2019
View reviewed changes
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
modules/mysql/failover_replica.tf Outdated Show resolved Hide resolved
modules/mysql/main.tf Outdated Show resolved Hide resolved
modules/postgresql/variables.tf Show resolved Hide resolved
modules/postgresql/variables.tf Show resolved Hide resolved
modules/postgresql/variables.tf Show resolved Hide resolved
modules/private_service_access/variables.tf Show resolved Hide resolved
test/fixtures/mysql-ha/main.tf Show resolved Hide resolved
aschiavon91
aschiavon91 reviewed Aug 8, 2019
View reviewed changes
variables.tf Outdated Show resolved Hide resolved
ivankorn
ivankorn reviewed Aug 9, 2019
View reviewed changes
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
helpers/terraform_validate Outdated Show resolved Hide resolved
modules/mysql/variables.tf Show resolved Hide resolved
modules/mysql/variables.tf Show resolved Hide resolved
modules/mysql/variables.tf Show resolved Hide resolved
modules/safer_mysql/variables.tf Show resolved Hide resolved
modules/safer_mysql/variables.tf Show resolved Hide resolved
@ingwarr ingwarr force-pushed the master branch 2 times, most recently from f19658d to 95781f5 Compare August 9, 2019 20:48
@ingwarr
Copy link
Contributor Author

ingwarr commented Aug 9, 2019

image
All tests passed

@nick4fake
Copy link

nick4fake commented Aug 12, 2019 •
edited
Loading

Approved

@ingwarr ingwarr marked this pull request as ready for review August 12, 2019 08:34
@aaron-lane aaron-lane self-assigned this Aug 28, 2019
@aaron-lane aaron-lane added the enhancement New feature or request label Aug 28, 2019
aaron-lane
aaron-lane suggested changes Aug 28, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
modules/mysql/failover_replica.tf Outdated Show resolved Hide resolved
modules/mysql/main.tf Outdated Show resolved Hide resolved
modules/safer_mysql/variables.tf Outdated Show resolved Hide resolved
modules/safer_mysql/variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
aschiavon91
aschiavon91 reviewed Sep 6, 2019
View reviewed changes
main.tf Outdated Show resolved Hide resolved
@ingwarr ingwarr force-pushed the master branch 2 times, most recently from e5cac7c to 0b9a49c Compare September 9, 2019 18:20
aaron-lane
aaron-lane previously requested changes Sep 12, 2019
View reviewed changes
Copy link
Contributor

@aaron-lane aaron-lane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be considerate about arbitrarily changing default values when they were previously undefined.

read_replica_disk_type in modules/mysql/variables.tf and failover_replica_pricing_plan in modules/safer_mysql/variables.tf should be typed.

modules/mysql/main.tf Outdated Show resolved Hide resolved
modules/mysql/variables.tf Show resolved Hide resolved
modules/mysql/variables.tf Outdated Show resolved Hide resolved
modules/mysql/variables.tf Outdated Show resolved Hide resolved
modules/mysql/variables.tf Show resolved Hide resolved
modules/safer_mysql/variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@ingwarr ingwarr force-pushed the master branch 3 times, most recently from 3ab1793 to e49e705 Compare September 13, 2019 12:56
@ingwarr
Copy link
Contributor Author

ingwarr commented Sep 13, 2019

All tests passed
image

@ingwarr ingwarr requested a review from aaron-lane September 16, 2019 16:40
@aaron-lane aaron-lane changed the base branch from aaron-lane-0.12 to master September 23, 2019 21:04
@aaron-lane aaron-lane force-pushed the master branch 2 times, most recently from 7f5404f to f6bf9f3 Compare September 25, 2019 17:48
@aaron-lane aaron-lane dismissed their stale review September 25, 2019 17:49

Committed fixes

@aaron-lane
Copy link
Contributor

aaron-lane commented Sep 25, 2019 •
edited
Loading

I have tested again. All tests are green.

@aaron-lane aaron-lane merged commit 78e451f into terraform-google-modules:master Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivankorn ivankorn ivankorn left review comments

@aschiavon91 aschiavon91 aschiavon91 left review comments

@kopachevsky kopachevsky kopachevsky approved these changes

@nick4fake nick4fake nick4fake left review comments

@namusyaka namusyaka Awaiting requested review from namusyaka

@morgante morgante Awaiting requested review from morgante

@aaron-lane aaron-lane Awaiting requested review from aaron-lane

Assignees

@aaron-lane aaron-lane

Labels
cla: yes enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Terraform 0.12
7 participants
@ingwarr @nick4fake @aaron-lane @kopachevsky @aschiavon91 @ivankorn @googlebot