-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Terraform v0.12 #5 #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests fail on localhost as provided. The following additional change needs to be made:
- In
Makefile
, theDOCKER_TAG_BASE_KITCHEN_TERRAFORM
variable must be updated to2.0.0
so that the tests run against Terraform 0.12.x.
In general, please make sure that module tests are run before pull requests are submitted. I've created #7 to ensure that we get CI set up in a timely manner for this module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- CHANGELOG needs to be updated
- README needs to be updated
- Linting needs to be run
I run tests without docker before the push |
@ingwarr While I appreciate that, the contribution guidelines linked to in the README specifically encourage running tests in Docker. We should not merge a pull request with broken tests when executing in the documentation-suggested manner. |
@Jberlinsky Re-test Done |
|
@Jberlinsky command |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash all commits and add screenshots for tests after applying changes.
Fixes #5