Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace IAM module with IAM member resources #22

Merged
merged 2 commits into from
Nov 13, 2019

Conversation

aaron-lane
Copy link
Contributor

This branch fixes the IAM bindings in the project_cleanup submodule. Because that submodule creates a service account and then uses the account in additive IAM bindings, it can not use the IAM module as it only supports dynamic members in authoritative mode.

@aaron-lane aaron-lane added the bug Something isn't working label Nov 12, 2019
@aaron-lane aaron-lane requested a review from morgante November 12, 2019 21:16
@aaron-lane aaron-lane self-assigned this Nov 12, 2019
Aaron Lane added 2 commits November 12, 2019 16:23
The IAM module does not support dynamic members in additive mode.
@aaron-lane aaron-lane force-pushed the aaron-lane-dynamic-iam-members branch from cd76f34 to 8c6d9a5 Compare November 12, 2019 21:23
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but I thought we specifically discussed that dynamic values should be supported in the new IAM module if you're using a single member.

@aaron-lane aaron-lane merged commit b131c9f into master Nov 13, 2019
@aaron-lane aaron-lane deleted the aaron-lane-dynamic-iam-members branch November 13, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants