Reworked SA roles for old-projects cleanup. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulpalamarchuk
force-pushed
the
rework_sa_roles_for_cleanup
branch
from
2d0df00 to
21cbe2a
Compare
kopachevsky
approved these changes
Nov 8, 2019
morgante
suggested changes
Nov 8, 2019
modules/project_cleanup/main.tf
Outdated
| @@ -25,8 +30,9 @@ resource "google_service_account" "project_cleaner_function" { | |||
| } | |||
|
|
|||
| resource "google_organization_iam_member" "project_owner" { | |||
There was a problem hiding this comment.
Please just use the IAM module instead of building this list yourself: https://github.com/terraform-google-modules/terraform-google-iam/tree/master/modules/organizations_iam
paulpalamarchuk
force-pushed
the
rework_sa_roles_for_cleanup
branch
from
21cbe2a to
b83b1e9
Compare
paulpalamarchuk
force-pushed
the
rework_sa_roles_for_cleanup
branch
from
b83b1e9 to
1bb18ba
Compare
morgante
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.