Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support adding secrets from secret manager #123

Merged
merged 1 commit into from
May 12, 2023
Merged

feat: support adding secrets from secret manager #123

merged 1 commit into from
May 12, 2023

Conversation

bkamin29
Copy link
Contributor

@bkamin29 bkamin29 commented May 11, 2023 •
edited
Loading

@bkamin29 bkamin29 requested a review from a team as a code owner May 11, 2023 11:15
@bkamin29 bkamin29 force-pushed the feat/support_secret_manager_secrets branch from 16eb693 to 4231fc5 Compare May 11, 2023 11:16
@bkamin29 bkamin29 changed the title feat: suppose adding secrets from secret manager feat: support adding secrets from secret manager May 11, 2023
@bharathkkb
Copy link
Member

/gcbrun

bharathkkb
bharathkkb approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @bkamin29

@bharathkkb bharathkkb merged commit 5b8f226 into terraform-google-modules:master May 12, 2023
@release-please release-please bot mentioned this pull request May 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkamin29 @bharathkkb