Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for max_instances argument #66

Closed
fpoon opened this issue Dec 28, 2021 · 3 comments
Closed

Support for max_instances argument #66

fpoon opened this issue Dec 28, 2021 · 3 comments
Labels
enhancement New feature or request triaged Scoped and ready for work

Comments

@fpoon
Copy link
Contributor

fpoon commented Dec 28, 2021

TL;DR

Hi,
It seems that this module lacks support for cloud function max_instances argument, though the underlying event-function module seems to support it.
Adding this would protect users against unlimited scaling in case of pubsub malfunction (e.g. constant failing to acknowledge message and redelivering it, which might result in increasing number of cloud function instances)

Terraform Resources

No response

Detailed design

main.tf:
...
module "main" {
  ...
  max_instances = var.function_max_instances
  ...
}
...

variables.tf:
...
variable "function_max_intances" {
  type        = number
  default     = 0
  description = "The maximum number of parallel executions of the function."
}
...

Additional information

If you are ok with this proposal, I'll be happy to contribute code :)

@fpoon fpoon added the enhancement New feature or request label Dec 28, 2021
@bharathkkb
Copy link
Member

@fpoon happy to review a PR adding this

@bharathkkb bharathkkb added the triaged Scoped and ready for work label Feb 4, 2022
fpoon added a commit to fpoon/terraform-google-scheduled-function that referenced this issue Feb 11, 2022
@fpoon
Copy link
Contributor Author

fpoon commented Feb 14, 2022

Hi, here's the PR: #67

@apeabody
Copy link
Contributor

Completed in: #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged Scoped and ready for work
Projects
None yet
Development

No branches or pull requests

3 participants