Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch svpc access to explicit dep on service enablement #934

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

bharathkkb
Copy link
Member

@bharathkkb bharathkkb commented Aug 27, 2024

Context: b/362272932

@bharathkkb
Copy link
Member Author

Validated in test logs that google_project_iam_member in svpc access still awaits API enablement

After

module.example.module.service-project-b.module.project-factory.module.project_services.google_project_service.project_services["dataproc.googleapis.com"]: Still creating... [20s elapsed]
module.example.module.service-project-b.module.project-factory.module.project_services.google_project_service.project_services["dataproc.googleapis.com"]: Creation complete after 22s [id=.../dataproc.googleapis.com]
       ...
module.example.module.service-project-b.module.shared_vpc_access.google_project_iam_member.service_shared_vpc_user["dataproc.googleapis.com"]: Creating...
       ```

@bharathkkb bharathkkb marked this pull request as ready for review August 27, 2024 21:56
@bharathkkb bharathkkb requested a review from a team as a code owner August 27, 2024 21:56
@bharathkkb bharathkkb merged commit 105be42 into master Aug 28, 2024
8 checks passed
@bharathkkb bharathkkb deleted the explicit-svc-dep branch August 28, 2024 17:50
@bharathkkb bharathkkb restored the explicit-svc-dep branch August 28, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants