Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add depends_on to created_subnets data fetch #81

Merged
merged 2 commits into from
Oct 11, 2019
Merged

Add depends_on to created_subnets data fetch #81

merged 2 commits into from
Oct 11, 2019

Conversation

agno01
Copy link
Contributor

@agno01 agno01 commented Oct 10, 2019 •
edited
Loading

This is to fix #80

@agno01 agno01 requested review from andreyk-code and a team as code owners October 10, 2019 17:19
@agno01 agno01 changed the title [#26] Add depends_on to created_subnets data fetch [#80] Add depends_on to created_subnets data fetch Oct 10, 2019
@agno01 agno01 changed the title [#80] Add depends_on to created_subnets data fetch Add depends_on to created_subnets data fetch Oct 10, 2019
morgante
morgante suggested changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing this fix. Just one stylistic change.

main.tf Outdated Show resolved Hide resolved
@agno01 @morgante
remove quotes
f933614 
Co-Authored-By: Morgante Pell <[email protected]>
@agno01
Copy link
Contributor Author

agno01 commented Oct 10, 2019

What kind of check is the one failing?

@morgante
Copy link
Contributor

It's an integration test, but looks unrelated to your PR. I'm going to investigate/fix on our end.

@morgante morgante merged commit bc07616 into terraform-google-modules:master Oct 11, 2019
tfhartmann added a commit to tfhartmann/terraform-google-network that referenced this pull request Oct 11, 2019
@tfhartmann
rebase: add back depends_on for subnets after a rebase
aee0cc0 
Making sure
`depends_on = [google_compute_subnetwork.subnetwork]`

is correctly added in after a rebase as per terraform-google-modules#81
@erdebee erdebee mentioned this pull request Oct 29, 2019
Closed
@morgante morgante mentioned this pull request Oct 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@andreyk-code andreyk-code Awaiting requested review from andreyk-code

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Error in function call - google_compute_subnetwork.subnetwork is empty tuple
2 participants
@agno01 @morgante