Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vpc flow logs option to subnets #6

Merged
merged 4 commits into from
Sep 11, 2018
Merged

Add vpc flow logs option to subnets #6

merged 4 commits into from
Sep 11, 2018

Conversation

andreyk-code
Copy link
Contributor

@andreyk-code andreyk-code commented Sep 9, 2018 •
edited
Loading

Added enable VPC flow logs option to module and examples

morgante
morgante suggested changes Sep 10, 2018
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest adding a default of false for this new variable, otherwise LGTM.

main.tf Outdated Show resolved Hide resolved
Andrey Kumanov and others added 2 commits September 10, 2018 17:34
@morgante morgante merged commit 9977fa1 into terraform-google-modules:master Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreyk-code @morgante