Initial import of net-firewall submodule from internal version. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gentle ping, with a reminder that this code comes from an internal module, which has been in use for months, and this is just a move to this repo as part of the Fabric plan we drew together. |
aaron-lane
reviewed
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings in the net-firewall module as a submodule.
I added a new example and tests, as I was not too sure that adding the submodule to the simple example was fine.
I'm not too sure about the version bump in
inspec.yml, but it's the only way I could run verify witout Kitchen complaining about a version mismatch.This PR also contains a minimal fix to the combine docfiles script, so it doesn't fail when a match is not found (as happens in this repo).