Provide ability to delete default gateway route #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morgante
requested review from
morgante,
aaron-lane,
adrienthebo and
andreyk-code
glarizza
force-pushed
the
gl/25_delete_default_route
branch
5 times, most recently
from
bb91fae to
ad5f1b4
Compare
aaron-lane
suggested changes
Feb 20, 2019
aaron-lane
approved these changes
Feb 20, 2019
adrienthebo
reviewed
Feb 20, 2019
glarizza
force-pushed
the
gl/25_delete_default_route
branch
2 times, most recently
from
193e4e4 to
9c80d9e
Compare
This commit introduces the ability to delete the default gateway route that is created for the VPC network (issue terraform-google-modules#25). If the input variable `var.delete_default_internet_gateway_routes` is set then a null_resource uses the local-exec provisioner to execute a script that filters for all network routes within the `project_id` whose name begins with "default-route" and who contains a next hop of "default-internet-gateway" and then deletes them. This functionality is useful in the event that all egress traffic should be routed through a single device instead of directly to the default internet gateway. Without this change there is no way to automate the deletion of those routes.
glarizza
force-pushed
the
gl/25_delete_default_route
branch
from
9c80d9e to
d31726f
Compare
adrienthebo
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the ability to delete the default gateway route
that is created for the VPC network (issue #25). If the input variable
var.delete_default_internet_gateway_routesis set then a null_resourceuses the local-exec provisioner to execute a script that filters for all
network routes within the
project_idwhose name begins with"default-route" and who contains a next hop of "default-internet-gateway"
and then deletes them. This functionality is useful in the event that
all egress traffic should be routed through a single device instead of
directly to the default internet gateway. Without this change there is
no way to automate the deletion of those routes.