-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate integration tests to Test Kitchen #28
Merged
morgante
merged 3 commits into
terraform-google-modules:master
from
glarizza:gl/kitchen_terraform_tests
Feb 14, 2019
Merged
Migrate integration tests to Test Kitchen #28
morgante
merged 3 commits into
terraform-google-modules:master
from
glarizza:gl/kitchen_terraform_tests
Feb 14, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit contains all changes resulting from copying the module template over the existing module structure.
This commit eliminates the existing BATS integration tests and instead introduces integration tests with Test Kitchen using the kitchen-terraform and inspec-gcp plugins. The changes made to the examples were to ensure that all scenarios could be run in parallel, to correct syntax errors, and to use locals to make testing easier.
glarizza
force-pushed
the
gl/kitchen_terraform_tests
branch
9 times, most recently
from
February 13, 2019 23:26
cc9eb77
to
be1d9a6
Compare
aaron-lane
suggested changes
Feb 14, 2019
glarizza
force-pushed
the
gl/kitchen_terraform_tests
branch
from
February 14, 2019 20:18
ff9573c
to
4913f82
Compare
This commit includes changes necessary for enabling the integration testing CI pipeline being defined in Concourse. The Makefile has been updated to reference `test/ci_integration.sh` from the `make test_integration` target which will export the correct Cloud SDK environment variables based on environment variables coming out of the CI pipeline (namely `$SERVICE_ACCOUNT_JSON` and `$PROJECT_ID`), handle teardown of the environment correctly, and allow for the exit code of the verify step to be communicated back to CI (instead of the exit code from the destroy step). Also included is the `test/fixtures/simulated_ci_environment` scenario which can be used to setup a project and the same dependencies that are established by the CI pipeline. This will allow a module consumer to be able to test locally (or via the docker container) in the same way that CI testing is happening remotely.
glarizza
force-pushed
the
gl/kitchen_terraform_tests
branch
from
February 14, 2019 20:33
4913f82
to
446ef4c
Compare
aaron-lane
approved these changes
Feb 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR eliminates the existing BATS integration tests and instead
introduces integration tests with Test Kitchen using the
kitchen-terraform and inspec-gcp plugins. The changes made to the
examples were to ensure that all scenarios could be run in parallel, to
correct syntax errors, and to use locals to make testing easier.