Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds subnet data source, allows no secondary range in subnets; fixes #5 #19

Merged
merged 1 commit into from
Jan 10, 2019

Conversation

angstwad
Copy link
Contributor

@angstwad angstwad commented Nov 29, 2018

This will fix #5, which causes errors when the secondary_ranges map does not define any secondary ranges. This keeps the subnets_secondary_ranges output, but we might consider removing it altogether, since it is capable of producing such useless output as:

Outputs:

secondary_ranges = [
    [
    ],
    [
    ],
    [
    ]
]

Removing the output is something I'm happy to do, if that's the direction we choose to go.

@morgante morgante self-requested a review January 10, 2019 22:10
@morgante
Copy link
Contributor

Thanks for the contribution!

@morgante morgante merged commit 450e024 into terraform-google-modules:master Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating a network with no secondary ranges fails
2 participants