-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade examples to terraform-google-vm and add test automation #17
Upgrade examples to terraform-google-vm and add test automation #17
Conversation
b44ab81
to
381fc21
Compare
Requested changes I think should be resolved, and I opened a few additional issues where there are external dependencies. Added an additional test for presence of load balancer endpoint that gets created. Also updated README documentation to the same standards as some of the other CFT modules. I'll touch base separately about where I am on adding CI. |
The integration test I had to test the presence of the load balancer by hitting the endpoint fails for what it seems like the failure of the docker build container to access the internet. The basic functionality of the load balancer in GCP tests for the presence of the backend, but I think to complete an integration test we'd want to test the presence of the front end and forwarding rules. Are we doing any tests for Internet-facing endpoints like this anywhere else?
|
@zefdelgadillo We had some full integration tests like what you're describing in other modules, but they've since (to my knowledge, entirely) been removed or commented out because they were "flappy" -- even when they worked, there was no way to guarantee they worked consistently. |
@morgante or @Jberlinsky thank you both again for the reviews. would like to get a final once over and an approval if all looks good |
884d8d3
to
62a87b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tiny nits, almost there.
0334193
to
28d35a4
Compare
…ed testing - Add integration tests - Add lint tests - Use terraform-google-vm for basic example - Update changelog
28d35a4
to
4990b5f
Compare
make generate_docs
to work correctly)@morgante at long last, here's the (significant) PR that includes the change to use the new terraform-google-vm managed instance group examples. This included some refactor of the module in addition to adding the example. I also added the test automation that we have on the other newer modules, with a simple test for now that checks for the presence of the forwarding rule. We might want to include a test that checks for the presence of the backend.
I'll squash commits on an approval
closes #12
closes #14