Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for setting http_keep_alive_timeout_sec #425

Merged
merged 3 commits into from
May 18, 2024

Conversation

jimdaga
Copy link

@jimdaga jimdaga commented May 15, 2024

Purpose

Add support to configure the http_keep_alive_timeout_sec value when using an EXTERNAL_MANAGED Load Balancing Scheme.

Copy link

google-cla bot commented May 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jimdaga jimdaga changed the title Add support for setting http_keep_alive_timeout_sec feat: Add support for setting http_keep_alive_timeout_sec May 15, 2024
@jimdaga jimdaga marked this pull request as ready for review May 15, 2024 20:14
@jimdaga jimdaga requested review from imrannayer and a team as code owners May 15, 2024 20:14
@imrannayer imrannayer self-assigned this May 15, 2024
@imrannayer
Copy link
Collaborator

@jimdaga thx for the PR. Lint tests are failing. can u plz follow this doc and fix the issue.

@jimdaga
Copy link
Author

jimdaga commented May 17, 2024

Hi @imrannayer I have corrected the lint error. Please let me know if you have any other feedback, thank you!

@imrannayer
Copy link
Collaborator

/gcbrun

@imrannayer imrannayer merged commit 804b7b9 into terraform-google-modules:master May 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants