Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to disable Kubernetes SA annotation in workload-identity. #787

Merged
merged 3 commits into from
Jan 19, 2021

Conversation

martinivanov
Copy link
Contributor

This PR adds the option to disable Kubernetes SA annotation in the workload-identity module. This is useful in cases where an operator managing IAM doesn't have access to GKE or environments where GKE is managed in a declarative manner through GitOps, for example.

@comment-bot-dev
Copy link

comment-bot-dev commented Jan 14, 2021

Thanks for the PR! 🚀
✅ Lint checks have passed.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @martinivanov

@morgante
Copy link
Contributor

/gcbrun

@bharathkkb bharathkkb merged commit 4e4ce02 into terraform-google-modules:master Jan 19, 2021
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…identity. (terraform-google-modules#787)

* Add the option to disable Kubernetes SA annotation in workload-identity.

* Add the option to disable Kubernetes SA annotation in workload-identity. Generated documentation.

Co-authored-by: Bharath KKB <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants