Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add submodule and tests for private clusters #69

Merged
merged 7 commits into from
Feb 12, 2019

Conversation

Jberlinsky
Copy link
Contributor

No description provided.

autogen/README.md Outdated Show resolved Hide resolved
autogen/README.md Outdated Show resolved Hide resolved
autogen/README.md Outdated Show resolved Hide resolved
autogen/README.md Outdated Show resolved Hide resolved
examples/simple_regional_private/README.md Show resolved Hide resolved
helpers/generate_modules/generate_modules.py Show resolved Hide resolved
Copy link
Contributor

@adrienthebo adrienthebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we're autogenerating a bunch of code this changeset is pretty hefty. Are there specific areas you want reviewed more closely?

In addition there are some failing tests that look like they're still under development - do you want additional review at this time or do you want me to check back in a few days?

@Jberlinsky Jberlinsky force-pushed the feature/private-cluster-module branch from 5eabbfb to 70a324b Compare February 11, 2019 15:09
@Jberlinsky Jberlinsky force-pushed the feature/private-cluster-module branch from da87606 to a466549 Compare February 12, 2019 00:59
@Jberlinsky
Copy link
Contributor Author

@adrienthebo Thanks for checking in, and apologies for the delay. This PR is now in a workable state, and is ready for review.

This is indeed a hefty change, due to the consolidation of logic in autogen/. The particularly relevant bits of this PR are the changes in autogen/cluster_regional.tf and autogen/cluster_zonal.tf, as they template out the major differences between the public and private cluster modules. I also added two test cases (suffixed with _private) to test such clusters.

@Jberlinsky Jberlinsky changed the title [WIP] Add submodule and tests for private clusters Add submodule and tests for private clusters Feb 12, 2019
Copy link
Contributor

@adrienthebo adrienthebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While there's a large diff the main changes in this PR just deal with templating out a few resource variables. Changes look good, test coverage looks solid, let's merge this.

@Jberlinsky
Copy link
Contributor Author

Thanks @adrienthebo!

@aaron-lane could you kindly dismiss your review (or re-review if you're so inclined) so I can merge this?

@adrienthebo
Copy link
Contributor

Verified that this change does not cause any Terraform state changes when upgraded from master.

@adrienthebo adrienthebo merged commit 6189fef into master Feb 12, 2019
@adrienthebo adrienthebo deleted the feature/private-cluster-module branch February 12, 2019 17:40
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
…modules/feature/private-cluster-module

Add submodule and tests for private clusters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants