-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up submodule structure #61
Conversation
f4ddc42
to
73bbae2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small changes requested but otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I might have been unclear on expectations here.
We should not be including complex Terraform-specific logic. Nor should we be causing a backwards-incompatible change to the root module.
Instead, this should be a pretty small and simple change:
- Copying all the root files into an
autogen/
folder and making them into templates. We can use jinja2 or Go for templating (open to alternative suggestions). - A very simple script which copies the files from the autogen folder into the specific modules. To start we will have just one: public. Keep the private in a follow-up PR.
To be clear, for this PR, we should avoid any symlinks.
@morgante To be clear, the first iteration of this will be template generation from |
@Jberlinsky Yes, the addition of the private module can happen in a later PR. |
Co-Authored-By: Jberlinsky <[email protected]>
Co-Authored-By: Jberlinsky <[email protected]>
a3f7200
to
11588c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also make sure the generated files include a header explaining they are autogenerated (and pointing to the autogen folder).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merge once CI is green.
…modules/internal/submodule-structure Set up submodule structure
Per conversation in #51 (review) and offline:
./autogen
./modules
and creates apublic-cluster
module