Add variable to allow a pre-generated SSH key to be passed to the ACM module #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
paulpalamarchuk
commented
Nov 22, 2019
paulpalamarchuk
commented
- Fix Add var to allow a pre-generated SSH key to be passed to the ACM module #329
nick4fake
previously approved these changes
Nov 25, 2019
paulpalamarchuk
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
aaron-lane
suggested changes
Nov 26, 2019
modules/acm/variables.tf
Outdated
| variable "ssh_auth_key" { | ||
| description = "Key for Git authentication. Overrides 'create_ssh_key' variable." | ||
| type = string | ||
| default = "" |
There was a problem hiding this comment.
We should use null for empty defaults when possible.
Suggested change
| default = "" | |
| default = null |
There was a problem hiding this comment.
Set to "" because it's used in "local-exec" command
modules/acm/main.tf
Outdated
| @@ -18,7 +18,7 @@ locals { | |||
| cluster_endpoint = "https://${var.cluster_endpoint}" | |||
| token = data.google_client_config.default.access_token | |||
| cluster_ca_certificate = data.google_container_cluster.primary.master_auth.0.cluster_ca_certificate | |||
| private_key = var.create_ssh_key ? tls_private_key.git_creds[0].private_key_pem : "" | |||
| private_key = var.create_ssh_key && var.ssh_auth_key == "" ? tls_private_key.git_creds[0].private_key_pem : var.ssh_auth_key | |||
There was a problem hiding this comment.
Suggested change
| private_key = var.create_ssh_key && var.ssh_auth_key == "" ? tls_private_key.git_creds[0].private_key_pem : var.ssh_auth_key | |
| private_key = var.create_ssh_key && var.ssh_auth_key == null ? tls_private_key.git_creds[0].private_key_pem : var.ssh_auth_key |
paulpalamarchuk
force-pushed
the
add_var_to_pass_ssh-key_in_acm
branch
from
efece2f to
11797c4
Compare
aaron-lane
approved these changes
Dec 2, 2019
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…add_var_to_pass_ssh-key_in_acm Add variable to allow a pre-generated SSH key to be passed to the ACM module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.