Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cgroup & sysctls to safe-cluster & safe-cluster-update-variant #2214

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

j
Copy link

@j j commented Dec 13, 2024

No description provided.

@j j requested review from ericyz and a team as code owners December 13, 2024 17:48
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @j!

Can you please update the template(s) and regenerate the resulting docs. Thanks!

https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/CONTRIBUTING.md#templating

@j j force-pushed the feat/node-configs branch from 67dd293 to c719dd4 Compare December 16, 2024 22:53
@j
Copy link
Author

j commented Dec 16, 2024

@apeabody pushed!

@apeabody
Copy link
Contributor

/gcbrun

@apeabody apeabody self-assigned this Dec 17, 2024
@j j requested a review from apeabody December 17, 2024 19:08
@apeabody
Copy link
Contributor

/gcbrun

@apeabody
Copy link
Contributor

Hi @j - Thanks again for the contribution!

I've discussed this proposed change with the larger team, and the decision is to instead recommend using the beta-private-cluster or beta-private-cluster-update-variant modules. The purpose of the Safer Cluster modules are to only present a limited set of parameters in-line with the GKE hardening guide, the CIS framework, and other best practices. The beta-private-cluster or beta-private-cluster-update-variant modules provide the full range of parameters, and can also be configured in the same fashion as the Safer Cluster modules as needed.

Best Wishes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants