feat: support total_egress_bandwidth_tier #2207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: drfaust92 <[email protected]>
|
/gcbrun |
apeabody
requested changes
Dec 10, 2024
| @@ -263,6 +263,7 @@ The node_pools variable takes the following parameters: | |||
| | queued_provisioning | Makes nodes obtainable through the ProvisioningRequest API exclusively. | | Optional | | |||
| | gpu_sharing_strategy | The type of GPU sharing strategy to enable on the GPU node. Accepted values are: "TIME_SHARING" and "MPS". | | Optional | | |||
| | max_shared_clients_per_gpu | The maximum number of containers that can share a GPU. | | Optional | | |||
| | total_egress_bandwidth_tier | Specifies the total network bandwidth tier. | | Optional | | |||
There was a problem hiding this comment.
I believe the accepted values are "TIER_1" and "TIER_UNSPECIFIED". Let's include in the description similar to the other parameters.
There was a problem hiding this comment.
will check, its not reflected in provider docs
There was a problem hiding this comment.
Yeah, I pulled those from here:
| dynamic "network_performance_config" { | ||
| for_each = lookup(each.value, "total_egress_bandwidth_tier", "") != "" ? [1] : [] | ||
| content { | ||
| total_egress_bandwidth_tier = lookup(each.value, "total_egress_bandwidth_tier", "") |
There was a problem hiding this comment.
Would null or "TIER_UNSPECIFIED" be a better default value? (Not that it should be possible to ever use the default value here.)
There was a problem hiding this comment.
will check, probably null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.