Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the endpoint variable to be dependent on GKE cluster state #214

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Changed the endpoint variable to be dependent on GKE cluster state #214

merged 1 commit into from
Jul 23, 2019
+68 −0

Conversation

kevensen
Copy link
Contributor

Addresses #212

morgante
morgante suggested changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please be sure to regenerate docs (make generate_docs). I'm not sure why your commit is removing docs right now.

README.md Outdated Show resolved Hide resolved
@kevensen
Copy link
Contributor Author

@morgante My commit was removing the inputs due to me not running make generate_docs. That's been corrected.

Not sure why the lint tests are failing.

@morgante
Copy link
Contributor

@kevensen Can you unstage all README changes? Something is funky with your make generate_docs and your PR shouldn't need to update the README anyways.

@kevensen
Copy link
Contributor Author

When I run make generate it updates the README.md's.

I've backed out the changes to the README.md's.

morgante
morgante approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@morgante morgante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting failures look unrelated, once CI comes back green LGTM.

@kevensen
Copy link
Contributor Author

@morgante Thank you!

@morgante morgante merged commit 67f8a5f into terraform-google-modules:master Jul 23, 2019
aaron-lane added a commit that referenced this pull request Jul 24, 2019
@aaron-lane
Add entry for #214 to CHANGELOG
38446eb
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@morgante
Merge pull request terraform-google-modules#214 from kevensen/output-…
9804a38 
…updates

Changed the endpoint variable to be dependent on GKE cluster state
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@aaron-lane
Add entry for terraform-google-modules#214 to CHANGELOG
1fd2c56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgante morgante morgante approved these changes

@aaron-lane aaron-lane Awaiting requested review from aaron-lane

@adrienthebo adrienthebo Awaiting requested review from adrienthebo

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevensen @morgante