Private Cluster Configuration #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jberlinsky
force-pushed
the
feature/private-cluster-configuration
branch
from
2e36402 to
dfd5792
Compare
| default = false | ||
| } | ||
|
|
||
| variable "private_cluster_config_enable_private_endpoint" { |
There was a problem hiding this comment.
Varible name seems a bit long. Maybe consider an alternative like private_endpoint?
| default = false | ||
| } | ||
|
|
||
| variable "private_cluster_config_enable_private_nodes" { |
There was a problem hiding this comment.
Varible name seems a bit long. Maybe consider an alternative like private_nodes?
| default = false | ||
| } | ||
|
|
||
| variable "private_cluster_config_master_ipv4_cidr_block" { |
There was a problem hiding this comment.
Varible name seems a bit long. Maybe consider an alternative like private_master_ipv4_cidr?
|
Any updates on this PR? |
|
@miles- We're hoping to get this merged in over the next few days. Thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This switches the implementation of this module to require the
google-betaprovider to be configured. See discussion in #13 (comment)This PR has significant overlap with #20, and should not be merged (or really even reviewed) until #20 is.
Addresses #8