feat: add a flag to allow access through Google Cloud public IP addresses #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentgrangeau
requested review from
ericyz,
gtsorbo and
a team
as code owners
apeabody
changed the title
|
/gcbrun |
apeabody
previously requested changes
Sep 10, 2024
There was a problem hiding this comment.
Thanks for the contribution @laurentgrangeau!
From the INT tests:
TestSimpleZonalPrivate 2024-09-10T20:24:48Z command.go:100: Running command gcloud with args [config get-value project --format json]
TestSimpleZonalPrivate 2024-09-10T20:24:49Z command.go:185: "cloud-foundation-cicd"
golden.go:157:
Error Trace: /builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/golden/golden.go:157
/workspace/test/integration/simple_zonal_private/simple_zonal_private_test.go:70
/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:638
/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:670
/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/utils/stages.go:31
/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:670
Error: Not equal:
expected: "{\n \"cidrBlocks\": [\n {\n \"cidrBlock\": \"10.0.0.0/17\",\n \"displayName\": \"VPC\"\n }\n ],\n \"enabled\": true\n }"
actual : "{\n \"cidrBlocks\": [\n {\n \"cidrBlock\": \"10.0.0.0/17\",\n \"displayName\": \"VPC\"\n }\n ],\n \"enabled\": true,\n \"gcpPublicCidrsAccessEnabled\": false\n }"
Diff:
--- Expected
+++ Actual
@@ -7,3 +7,4 @@
],
- "enabled": true
+ "enabled": true,
+ "gcpPublicCidrsAccessEnabled": false
}
Test: TestSimpleZonalPrivate
Messages: expected masterAuthorizedNetworksConfig to match fixture {
"cidrBlocks": [
{
"cidrBlock": "10.0.0.0/17",
"displayName": "VPC"
}
],
"enabled": true
}
apeabody
reviewed
Sep 11, 2024
|
Thanks @laurentgrangeau! Let's also add the new |
|
/gcbrun |
apeabody
reviewed
Sep 17, 2024
…access_enabled in not null
|
/gcbrun |
|
/gcbrun |
apeabody
requested changes
Sep 19, 2024
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
From the test: |
|
/gcbrun |
apeabody
reviewed
Sep 23, 2024
test/integration/simple_zonal_private/testdata/TestSimpleZonalPrivate.json
Outdated
Show resolved
Hide resolved
apeabody
reviewed
Sep 23, 2024
test/integration/simple_zonal_private/testdata/TestSimpleZonalPrivate.json
Outdated
Show resolved
Hide resolved
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
apeabody
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a flag to allow access through Google Cloud public IP addresses only. This is usefull to increase security in private cluster mode