Updating google providers to 2.9 #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marko7460
requested review from
aaron-lane,
adrienthebo,
Jberlinsky and
morgante
as code owners
morgante
previously approved these changes
Jun 27, 2019
marko7460
force-pushed
the
update_provider
branch
from
b50d759 to
6600584
Compare
morgante
previously approved these changes
Jun 27, 2019
marko7460
force-pushed
the
update_provider
branch
from
6600584 to
a4a89c9
Compare
Your taint test failed. The nodepool example it is adding a |
|
@chrislovecnm that test has been intermittently failing for a while. we removed it in #171. |
|
Ah, we did not remove the test correctly. The assertion should have been updated to look for a partial match of tags rather than an exact match. |
|
@aaron-lane Fix is in #200. Once that gets merged i will rebase this branch. |
marko7460
force-pushed
the
update_provider
branch
from
b2d0562 to
4c8f8f5
Compare
aaron-lane
suggested changes
Jun 27, 2019
marko7460
force-pushed
the
update_provider
branch
from
b1ba610 to
272156c
Compare
morgante
approved these changes
Jun 27, 2019
aaron-lane
added a commit
that referenced
this pull request
Jun 28, 2019
aaron-lane
added a commit
that referenced
this pull request
Jun 28, 2019
aaron-lane
added a commit
that referenced
this pull request
Jul 8, 2019
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…_provider Updating google providers to 2.9
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.