Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Add protect_config beta feature #1617

Merged
merged 4 commits into from
Jun 6, 2023
Merged

feat!: Add protect_config beta feature #1617

merged 4 commits into from
Jun 6, 2023

Conversation

NissesSenap
Copy link
Contributor

@NissesSenap NissesSenap commented Apr 25, 2023 •
edited by apeabody
Loading

fix: #1586

BEGIN_COMMIT_OVERRIDE
feat: Add protect_config beta feature (#1617)
END_COMMIT_OVERRIDE

@google-cla
Copy link

google-cla bot commented Apr 25, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@NissesSenap NissesSenap force-pushed the fix/1586 branch 2 times, most recently from 026c76d to c27c19d Compare April 25, 2023 14:16
@NissesSenap NissesSenap marked this pull request as ready for review April 25, 2023 14:17
@NissesSenap NissesSenap requested review from a team, Jberlinsky and ericyz as code owners April 25, 2023 14:17
@ericyz ericyz self-assigned this May 7, 2023
@ericyz ericyz changed the title feat: Add protect_config beta feature feat!: Add protect_config beta feature May 7, 2023
ericyz
ericyz requested changes May 7, 2023
View reviewed changes
Copy link
Collaborator

@ericyz ericyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestion for review

@NissesSenap NissesSenap requested a review from ericyz May 8, 2023 06:43
@ericyz
Copy link
Collaborator

ericyz commented May 10, 2023

LGTM and will approve after the test

@ericyz
Copy link
Collaborator

ericyz commented May 10, 2023

LGTM and will approve after the int test

@bharathkkb
Copy link
Member

@NissesSenap looks like there are some validate failures

https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/actions/runs/4943651436/jobs/8838343712

@NissesSenap
Copy link
Contributor Author

I have fixed that now @bharathkkb
I tried running make docker_test_integration but there are a number of things that didn't pass. But I don't think they have anything to do with my changes.

So hopefully everything should pass now in the CI

@NissesSenap
Copy link
Contributor Author

ping @ericyz @bharathkkb

@NissesSenap
Copy link
Contributor Author

ping @ericyz @bharathkkb
I have rebased again, would love to run the pipeline again and hopefully a merge

@ericyz
Copy link
Collaborator

ericyz commented Jun 6, 2023

/gcprun

@ericyz ericyz merged commit d252579 into terraform-google-modules:master Jun 6, 2023
@release-please release-please bot mentioned this pull request Jun 6, 2023
Merged
@NissesSenap NissesSenap deleted the fix/1586 branch June 6, 2023 05:36
@ebeltramo96 ebeltramo96 mentioned this pull request Jul 18, 2023
Closed
@michaellzc michaellzc mentioned this pull request Nov 23, 2023
Merged
@yorik yorik mentioned this pull request May 14, 2024
Closed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@NissesSenap
feat!: Add protect_config beta feature (terraform-google-modules#1617)
dbdfabc 
feat!: add protect_config beta feature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericyz ericyz ericyz approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees

@ericyz ericyz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for GKE Protect/Security Posture
3 participants
@NissesSenap @ericyz @bharathkkb