-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(acm)!: prevent conflicts in IAM binding #1576
fix(acm)!: prevent conflicts in IAM binding #1576
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
/gcbrun |
Thanks for the contribution @evenh, relevant output from LINT:
|
When using both config sync and policy controller the existing binding resources conflicts with each other and causes a constant diff.
/gcbrun |
My suspicion is the failing INT is unrelated. |
I don't have insight into the integration tests but I hope it is unrelated |
re-triggering CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @evenh!
When using both config sync and policy controller the existing binding resources conflicts with each other and causes a constant diff.
This PR will cause a diff in existing configurations, but when applying it should actually apply the the binding to both members resulting in the intended outcome and no further diffs.