-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: promote gce_pd_csi_driver to GA #1509
feat!: promote gce_pd_csi_driver to GA #1509
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @mnahkies
Agreed regarding default and can we add a small upgrade guide to call this out showing how users can set this to false similar to https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/docs/upgrading_to_v24.0.md#master_global_access_enabled-in-ga-private-cluster-module
Thanks for the review @bharathkkb - I've synced in changes from master and added an upgrade guide. I took the liberty of including a note about #1495 as I noticed there was no guide for it's changes that are scheduled for release in #1512 - though please let me know if that should be added elsewhere / omitted. |
@mnahkies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mnahkies!
Promotes the
gce_pd_csi_driver
variable to GA, as it has been GA in GKE since:Notes
versions.tf.tmp
doesn't need updating, as the underlying config was made GA in an earlier version than already specifiedQuestions