Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix windows example to use containerd #1449

Merged
merged 2 commits into from
Nov 3, 2022
Merged

chore: fix windows example to use containerd #1449

merged 2 commits into from
Nov 3, 2022

Conversation

bharathkkb
Copy link
Member

Windows example tests seem to be flaky. This swaps the example to use containerd variant.

     module.this.module.gke.google_container_node_pool.windows_pools["win-pool-01"]: Creating...
       
       Error: error creating NodePool: googleapi: Error 400: Creation of node pools using node images based on Docker container runtimes is not supported in GKE v1.23. This is to prepare for the removal of Dockershim in Kubernetes v1.24. We recommend that you migrate to image types based on Containerd (examples). For more information, contact Cloud Support., badRequest

@bharathkkb bharathkkb marked this pull request as ready for review November 3, 2022 02:33
@bharathkkb bharathkkb requested review from a team and Jberlinsky as code owners November 3, 2022 02:33
@comment-bot-dev
Copy link

@bharathkkb
Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb bharathkkb merged commit 92ebb00 into master Nov 3, 2022
@bharathkkb bharathkkb deleted the bharathkkb-patch-3 branch November 3, 2022 05:44
@michaellzc michaellzc mentioned this pull request Nov 23, 2023
Merged
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@bharathkkb
chore: fix windows example to use containerd (terraform-google-module…
4a6f2ae 
…s#1449)

* chore: fix windows example to use containerd

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeabody apeabody apeabody approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bharathkkb @comment-bot-dev @apeabody