Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed GitHub Issue #1445 | location_policy permadrifting #1448

Closed
wants to merge 10 commits into from
Closed

fixed GitHub Issue #1445 | location_policy permadrifting #1448

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
14259b5
fixed GitHub Issue #1445 | location_policy permadrifting
Nov 2, 2022
264a152
added location_policy, variable is user configurable
Nov 3, 2022
bfecebe
make build commit
Nov 3, 2022
45cd608
fixed GitHub Issue #1445 | location_policy permadrifting
Nov 2, 2022
8288f09
added location_policy, variable is user configurable
Nov 3, 2022
eaf8a9c
make build commit
Nov 3, 2022
4008545
Update autogen/main/cluster.tf.tmpl
QBYMKPI Nov 3, 2022
b00d3f7
Made changes to location_policy for spot vms
QBYMKPI Nov 4, 2022
7c106fe
changed autogen
QBYMKPI Nov 4, 2022
f0b5458
make build
QBYMKPI Nov 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions cluster.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,8 +324,9 @@ resource "google_container_node_pool" "pools" {
dynamic "autoscaling" {
for_each = lookup(each.value, "autoscaling", true) ? [each.value] : []
content {
min_node_count = lookup(autoscaling.value, "min_count", 1)
max_node_count = lookup(autoscaling.value, "max_count", 100)
location_policy = "BALANCED"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make the change in https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/tree/master/autogen and run make build. It would also be good to expose as an option to make it user configurable.

min_node_count = lookup(autoscaling.value, "min_count", 1)
max_node_count = lookup(autoscaling.value, "max_count", 100)
}
}

Expand Down