Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cloud-dns support #1317

Merged
merged 5 commits into from
Jul 23, 2022

Conversation

DrFaust92
Copy link
Contributor

Closes #1013
Continues from #1198 (thanks SamLR)

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @DrFaust92
One question

modules/beta-autopilot-private-cluster/cluster.tf Outdated Show resolved Hide resolved
@comment-bot-dev
Copy link

@DrFaust92
Thanks for the PR! 🚀
✅ Lint checks have passed.

@DrFaust92 DrFaust92 requested a review from bharathkkb July 21, 2022 18:58
@bharathkkb bharathkkb merged commit 4bf0011 into terraform-google-modules:master Jul 23, 2022
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
* cloud-dns support

* fix

* lint

* autopilot

Co-authored-by: Bharath KKB <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud DNS for GKE Clusters
3 participants